Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/border width #424

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feature/border width #424

wants to merge 5 commits into from

Conversation

YinDongFang
Copy link

@YinDongFang YinDongFang commented Feb 6, 2025 •
edited
Loading

  1. Support borderWidth
  2. Only show grid line in rounded area

image

@YinDongFang
Copy link
Author

@mosch Please take a moment to review. Thanks.

@mosch
Copy link
Owner

mosch commented Feb 8, 2025 •
edited
Loading

Hey @YinDongFang , thanks for the change! I don't understand why that is useful? What benefit does this have over wrapping the Editor into a div with a border?

@YinDongFang
Copy link
Author

Thanks for your review!
I'm using this great library in my project. Border and grid style changes were requested by our UI as new requirements. I found the borderColor property was already support by previous PR, but can't set width. So I implemented borderWidth as optional properties. I also adjusted grid line style, I think it's looks better in circle shape mask. If used as rect shape, it also can display use borderColor and borderWidth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YinDongFang @mosch