Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NonTransfer proxy filter #3140

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Jan 20, 2025

⚠️ Breaking Changes ⚠️

Identity calls add_sub and set_subs will no longer be callable from a NonTransfer proxy.

@RomarQ RomarQ requested a review from stiiifff January 20, 2025 11:07
@RomarQ RomarQ self-assigned this Jan 20, 2025
@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes labels Jan 20, 2025
Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2264 KB (no changes) ✅

Moonbeam runtime: 2236 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2264 KB (+236 KB compared to latest release) ⚠️

Moonbeam runtime: 2236 KB (+224 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+228 KB compared to latest release) ⚠️

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes and removed B0-silent Changes should not be mentioned in any release notes labels Jan 20, 2025
@RomarQ RomarQ marked this pull request as ready for review January 20, 2025 11:26
Copy link
Contributor

Coverage Report

@@                      Coverage Diff                       @@
##           perm-runtime-3401   rq/update-proxy      +/-   ##
==============================================================
- Coverage              74.59%            74.57%   -0.02%     
- Files                    377               375       -2     
- Lines                  96033             95691     -342     
==============================================================
- Hits                   71632             71359     -273     
- Misses                 24401             24332      -69     
Files Changed Coverage
/node/cli/src/command.rs 16.86% (-0.06%) 🔽
/node/service/src/lib.rs 62.26% (-0.02%) 🔽
/node/service/src/rpc.rs 85.00% (+0.05%) 🔼
/pallets/moonbeam-lazy-migrations/src/lib.rs 80.65% (+1.30%) 🔼
/pallets/moonbeam-lazy-migrations/src/tests.rs 98.15% (+0.34%) 🔼
/pallets/parachain-staking/src/lib.rs 91.79% (-0.16%) 🔽
/pallets/parachain-staking/src/mock.rs 97.70% (-0.06%) 🔽
/pallets/parachain-staking/src/tests.rs 90.85% (-0.04%) 🔽
/pallets/parachain-staking/src/weights.rs 38.35% (-1.92%) 🔽
/precompiles/identity/src/lib.rs 90.22% (+0.02%) 🔼
/primitives/account/src/lib.rs 62.50% (-2.34%) 🔽
/runtime/moonbase/src/lib.rs 52.60% (+2.00%) 🔼
/runtime/moonbase/src/weights/pallet_parachain_staking.rs 19.45% (-2.50%) 🔽
/runtime/moonbase/src/weights/pallet_treasury.rs 0.00% (-13.24%) 🔽
/runtime/moonbase/tests/common/mod.rs 97.07% (-0.03%) 🔽
/runtime/moonbase/tests/integration_test.rs 99.38% (-0.04%) 🔽
/runtime/moonbeam/src/lib.rs 46.89% (+2.24%) 🔼
/runtime/moonbeam/src/weights/pallet_assets.rs 8.88% (+0.25%) 🔼
/runtime/moonbeam/src/weights/pallet_parachain_staking.rs 19.36% (-2.49%) 🔽
/runtime/moonbeam/src/weights/pallet_treasury.rs 0.00% (-13.24%) 🔽
/runtime/moonbeam/tests/common/mod.rs 94.74% (-0.06%) 🔽
/runtime/moonbeam/tests/integration_test.rs 99.38% (-0.03%) 🔽
/runtime/moonriver/src/lib.rs 47.11% (+2.24%) 🔼
/runtime/moonriver/src/weights/pallet_assets.rs 8.88% (+0.25%) 🔼
/runtime/moonriver/src/weights/pallet_parachain_staking.rs 19.36% (-2.49%) 🔽
/runtime/moonriver/src/weights/pallet_treasury.rs 0.00% (-13.24%) 🔽
/runtime/moonriver/tests/common/mod.rs 94.85% (-0.06%) 🔽
/runtime/moonriver/tests/integration_test.rs 99.36% (-0.03%) 🔽

Coverage generated Mon Jan 20 11:40:43 UTC 2025

@RomarQ RomarQ requested a review from manuelmauro January 20, 2025 12:05
@stiiifff stiiifff merged commit 69ee7ab into perm-runtime-3401 Jan 20, 2025
56 of 61 checks passed
@stiiifff stiiifff deleted the rq/update-proxy branch January 20, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants