This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Using TypeExtensionPoints and CustomExtensionAttributes fail #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onAttribute. Using CustomExtensionAttribute on several TypeExtensionNodes didn't assign extension nodes to the correct extension points. Therefore, calling AddInEngine.GetExtensionNodes(typeof(IAnyInterface)) also returned extension nodes of another interface. Equivalent to ExtensionAttribute, CustomExtensionAttribute with property Type now. CustomAttribute with a list of nodes and properties (@IAssemblyReflector.cs) Reflector.cs/DefaultAssemblyReflector.cs now returns a list of properties and a list of nodes. Properties are needed to get value of property Type. AddinScanner now checks property Type of CustomExtensionAttribute, otherwise (equivalent to ExtensionAttribute) the base types are analyzed and used as path.
… an ExtensionNode still was loaded immediately before Shutdown, so ResetCachedData of Registry accessed the already uninitialized AddinEngine. Also there was a different behavior between using Mono.Cecil and .NET Reflection using a derived version from CustomExtensionAttribute. When using AddInRegistry.GetAddinDescription, extension nodes were not found, because AddinScanResult.GetAssemblyLocation did not resolve to the startup directory (in our case here are all needed assemblies located).
|
That's not how CustomExtensionAttribute is intended to be used. You can't use the same CustomExtensionAttribute subclass to define two different type extension points. Each extension point must have its own attribute class. The attribute type identifies the extension point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type Extension Points didn't work correctly, when using CustomExtensionAttribute. Using CustomExtensionAttribute on several TypeExtensionNodes didn't assign extension nodes to the correct extension points. Therefore, calling AddInEngine.GetExtensionNodes(typeof(IAnyInterface)) also returned extension nodes of another interface.
Equivalent to ExtensionAttribute, CustomExtensionAttribute with property Type now.
CustomAttribute with a list of nodes and properties (@IAssemblyReflector.cs)
Reflector.cs/DefaultAssemblyReflector.cs now returns a list of properties and a list of nodes. Properties are needed to get value of property Type.
AddinScanner now checks property Type of CustomExtensionAttribute, otherwise (equivalent to ExtensionAttribute) the base types are analyzed and used as path.