This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Try avoiding emitting assembly to run setup process - rebased #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path was being created without the path separator for the Mono.Addins.SetupProcess assembly. Also the file extension was incorrectly set to .dll when running with Mono.
The project was hard coded to target .NET 4.7.2 instead of using the TargetFramework.props file. This was preventing it being referenced by the UnitTests project.
The tests do not run tests with the external SetupProcess currently but having the UnitTests copy this allows this to be tested locally by changing the AddinDatabase.GetSetupHandler method.
mrward
force-pushed
the
dev/mrward/ns2.0-rebased
branch
from
3b3731d to
8ea73dd
Compare
Fixed the setup process tool trying to use too many command line arguments. The out directory is passed on stdin not as a command line argument.
|
OK down to just two failing tests with the external setup process tool. |
|
Down to one failing test. |
mrward
force-pushed
the
dev/mrward/ns2.0-rebased
branch
from
63ae0cd to
28be40a
Compare
|
OK this is working now. The last commit was not needed. The last two failing tests were not supposed to be run 'isolated'. I changed the addindatabase to always return the SetupProcess which is not right. Now all tests are green if I only return SetupProcess when RequiresIsolation is true. |
Therzok
approved these changes
Feb 10, 2021
|
I have pulled these changes into the .netstandard 2.0 branch PR - #171 So not sure if this PR on its own is needed. There still needs to be some work done in the other branch for .NET Core/.NET 5. Have only been looking at getting the tests passing so far. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some problems with the original PR #149