Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #2319

Merged
merged 1 commit into from
Aug 12, 2024
Merged

bug fix #2319

merged 1 commit into from
Aug 12, 2024

Conversation

samnlindsay
Copy link
Contributor

@samnlindsay samnlindsay commented Aug 9, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

No

Give a brief description for the solution you have provided

Completeness chart failed when specifying source_name due to the GROUP BY expression assuming the column is already named "source_dataset". Fixing it to refer to the source_name value.

@RobinL RobinL merged commit 9b77b79 into splink3_maintenance Aug 12, 2024
2 checks passed
@RobinL RobinL deleted the completeness_bug branch August 12, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants