Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug giving warning messages in term_frequencies.py #2204

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion splink/term_frequencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def tf_adjustment_chart(
most_freq = True if not n_most_freq else df["most_freq_rank"] < n_most_freq
mask = selected | least_freq | most_freq

vals_not_included = [val for val in vals_to_include if val not in df["value"]]
vals_not_included = [val for val in vals_to_include if val not in df["value"].values]
if vals_not_included:
warnings.warn(
f"Values {vals_not_included} from `vals_to_include` were not found in "
Expand Down
Loading