(feat) #2198 add postgres backend similarity functions to fully supported #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Hepworth <[email protected]>
Co-authored-by: Zoe Slade <[email protected]>
…ervices/bugfix_predict_threshold Minor bug in filtering predict table
…ervices/docs/updating_settings_validation_documentation Update documentation on settings validation in response to code changes
…ervices/docs_tweak Remove reference to github action that will not come to be
Co-authored-by: Zoe Slade <[email protected]>
…ster Fixing spurious error messages with Databricks enable_splink
Fix Splink 4 blog post link
…cross-platform Make spellcheck work cross-platform
…unctions to fully support comparisons
|
Hi @vfrank66 thanks very much for this. We're a bit short staffed at the moment but will endeavour to review ASAP. Don't worry too much about the test failures for now |
|
Hi @vfrank66 i've started to have a look at this, and do some experiments. All working so far. Could I double check - are the implementations of the new similarity functions in To make it easier to get the tests passing, I'll probably create a new PR of your commits on the main repo, so I can start to add commits on top until I'm happy with all the tests. Then I can check with you before merging. |
|
Closing in favour of #2224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt comparisons
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
2198 add similarity functions to postgres backend to enable comparison_level_library
Give a brief description for the solution you have provided
There are two options creating using the existing pg_similarity extension, or codifing the specific functions. I added the specific functions to implement comparison level library for postgres.
PR Checklist
I could not find the developer docs 404 not found so i did not add tests or docs, but I did run the linter. UPDATE: nevermind I guess I did not run the formatting. The lint_and_format.sh is not up-to-date with ruff do you want this updated as well. It is very confusing I am getting more ruff errors locally than I changed something is off.