-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update load settings and make it the defacto load logic #1921
Merged
ThomasHepworth
merged 13 commits into
master
from
update_load_settings_and_make_it_the_defacto_load_logic
Feb 6, 2024
Merged
Update load settings and make it the defacto load logic #1921
ThomasHepworth
merged 13 commits into
master
from
update_load_settings_and_make_it_the_defacto_load_logic
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
…' into add_comparison_level_validation_check
All looks good to me, once it's pointed at master and the checks are passing, happy to approve |
Co-authored-by: Robin Linacre <[email protected]>
…level_validation_check Add comparison level validation check
@RobinL see CI/CD checks. |
RobinL
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Should aid in simplifying this process, simplifying a lot of the code involved with the settings objects - #1669
Give a brief description for the solution you have provided
This PR consolidates our settings loading logic, moving everything into a singular method irrespective of the input type.
The goal with these changes is to simplify how a settings object interacts with our validation steps and to also simplify any future changes to our settings class.
For some context on the problem, there are three different scenarios in which we handle a "settings object":
None
With (1), we simply need to setup a cache uid to help with storing any outputs (some charts can still be run, even without any settings) and then short-circuit the code (no settings to process).
With (2) and (3), we essentially want to process the settings in the same way, but some of our environment variables may differ. We therefore need to take into account the fact that:
We were already checking the dialect and invalidating the cache, but I've added some changes to the UID to (fingers crossed) ensure it isn't as fragile. More on this below.
In summary
Why?
How?
load_settings
andsetup_settings_obj
functions. More in this previously closed PR.load_settings
method.PR Checklist