-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clusters topic guide #1883
Clusters topic guide #1883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks in good shape, thanks for all your work in this! Think you have done a good job explaining complicated things clearly, think this will be a really good addition to the docs
docs/topic_guides/evaluation/clusters/how_to_compute_metrics.md
Outdated
Show resolved
Hide resolved
docs/topic_guides/evaluation/clusters/how_to_compute_metrics.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from my side now - @zslade please merge whenever you are happy
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Give a brief description for the solution you have provided
Note to reviewers: This is a work in progress and may undergo some significant changes in light of developing plots for metrics and doing more thinking about how they should best be used!
Topic guide for evaluating clusters. Consists of:
At present, there isn't a focussed discussion on the various levers that can be pulled to change clusters (e.g. threshold vs constraints of comparisons vs blocking rules) which might be useful. Could wait for future iteration though.
PR Checklist