Explicitly cast postgres function return values #1693
Conversation
Two database functions fail in some versions of postgres, because their output is not explicitly cast to match the expected function return value type. This change simply does the explicit casting to match.
|
A word of warning though @sluhn-harrisr - from my testing it seems like there might be some other issues which could arise also using older versions of Postgres, which might be more closely linked to the inner workings of Splink. I haven't looked in great deal so not sure exactly which bits of functionality are effected, so you may well be fine. |
|
Thank you both @ADBond and @RobinL. Aside from these two functions things have been going well so far; fingers crossed it's all good from here. As for the mechanics of the PR - who does the merging into the master branch of the project? Is that me, now that it's reviewed and approved, or do you do that? |
|
Sorry - got interrupted part-way through there, have now merged! |
Two database functions fail in some versions of postgres, because their output is not explicitly cast to match the expected function return value type. This change simply does the explicit casting to match.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Closes #1685
Give a brief description for the solution you have provided
The original issue was with the
ave_months_betweenfunction that returnedfloat8values. I fixed that one and then the integer version failed in the same way, so i fixed that one too.After doing that, I was able to successfully instantiate a
PostgresLinkerobject, and I confirmed that the database functions were all created successfullyPR Checklist
Note - i ran the linter and it did report some stuff, but nothing in the two places changed by this commit (of course, since it was such a simple change to some string values). so I considered those linter messages to be irrelevant here.