fixup typing

moj-analytical-services · Jan 20, 2025 · 89560d3 · 89560d3
1 parent 07b65ee
commit 89560d3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/splink/internals/comparison.py b/splink/internals/comparison.py
@@ -61,19 +61,19 @@ class Comparison:
 
     def __init__(
         self,
-        comparison_levels: List[ComparisonLevel | dict],
+        comparison_levels: List[ComparisonLevel | dict[str, Any]],
         sqlglot_dialect: str,
         output_column_name: str = None,
         comparison_description: str = None,
         column_info_settings: ColumnInfoSettings = None,
     ):
-        comparison_levels: list[ComparisonLevel] = [
+        comparison_levels_as_objs: list[ComparisonLevel] = [
             ComparisonLevel(**cl, sqlglot_dialect=sqlglot_dialect)
             if isinstance(cl, dict)
             else cl
             for cl in comparison_levels
         ]
-        self.comparison_levels: list[ComparisonLevel] = comparison_levels
+        self.comparison_levels: list[ComparisonLevel] = comparison_levels_as_objs
 
         self._column_info_settings: Optional[ColumnInfoSettings] = column_info_settings
 

diff --git a/splink/internals/realtime.py b/splink/internals/realtime.py
@@ -65,7 +65,7 @@ def set(
     @staticmethod
     def _cache_id(
         settings: SettingsCreator | dict[str, Any] | Path | str, sql_dialect_str: str
-    ):
+    ) -> str:
         if isinstance(settings, SettingsCreator):
             return str(id(settings))
         if isinstance(settings, str):