update notebooks

moj-analytical-services · May 16, 2024 · 4861c7e · 4861c7e
1 parent 062b0f0
commit 4861c7e
Show file tree

Hide file tree

Showing 6 changed files with 174 additions and 210 deletions.
diff --git a/docs/demos/examples/duckdb/deduplicate_50k_synthetic.ipynb b/docs/demos/examples/duckdb/deduplicate_50k_synthetic.ipynb
@@ -400,7 +400,6 @@
     "    blocking_rule_creators=blocking_rules,\n",
     "    db_api=db_api,\n",
     "    link_type=\"dedupe_only\",\n",
-    "    unique_id_column_name=\"unique_id\",\n",
     ")"
    ]
   },

diff --git a/docs/demos/examples/duckdb/deterministic_dedupe.ipynb b/docs/demos/examples/duckdb/deterministic_dedupe.ipynb
@@ -324,7 +324,6 @@
     "    ],\n",
     "    db_api=db_api,\n",
     "    link_type=\"dedupe_only\",\n",
-    "    unique_id_column_name=\"unique_id\",\n",
     ")"
    ]
   },

diff --git a/docs/demos/examples/duckdb/transactions.ipynb b/docs/demos/examples/duckdb/transactions.ipynb
diff --git a/docs/demos/examples/sqlite/deduplicate_50k_synthetic.ipynb b/docs/demos/examples/sqlite/deduplicate_50k_synthetic.ipynb
@@ -270,8 +270,7 @@
     "    table_or_tables=df,\n",
     "    blocking_rule_creators=blocking_rules,\n",
     "    db_api=db_api,\n",
-    "    link_type=\"dedupe_only\",\n",
-    "    unique_id_column_name=\"unique_id\",\n",
+    "    link_type=\"dedupe_only\"\n",
     ")"
    ]
   },

diff --git a/docs/demos/tutorials/03_Blocking.ipynb b/docs/demos/tutorials/03_Blocking.ipynb
diff --git a/splink/internals/blocking_analysis.py b/splink/internals/blocking_analysis.py
@@ -606,7 +606,7 @@ def cumulative_comparisons_to_be_scored_from_blocking_rules_chart(
     blocking_rule_creators: Iterable[Union[BlockingRuleCreator, str, Dict[str, Any]]],
     link_type: user_input_link_type_options,
     db_api: DatabaseAPISubClass,
-    unique_id_column_name: str,
+    unique_id_column_name: str = "unique_id",
     max_rows_limit: int = int(1e9),
     source_dataset_column_name: Optional[str] = None,
 ) -> ChartReturnType: