-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(enhanced): refactor hoisting plugins #3488
fix(enhanced): refactor hoisting plugins #3488
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
89d35b0
into
remove-hoisted-runtime-experiment
Description
This pull request includes several changes across multiple files to improve the configuration and runtime behavior of the application. The most important changes include updates to the webpack configuration, enhancements to the Module Federation Plugin, and adjustments to the startup chunk dependencies.
Webpack Configuration Updates:
apps/manifest-demo/3009-webpack-provider/webpack.config.js
: AddeddevMiddleware
configuration to write files to disk in development mode.apps/manifest-demo/webpack-host/webpack.config.js
: Disabled the runtime option for theModuleFederationPlugin
.apps/modernjs/modern.config.ts
: Disabled the runtime option for theModuleFederationPlugin
.Module Federation Plugin Enhancements:
packages/enhanced/src/lib/container/ContainerPlugin.ts
: Removed the check for a single runtime chunk and always set the runtime option. [1] [2]packages/enhanced/src/lib/container/runtime/EmbedFederationRuntimePlugin.ts
: Simplified the logic for handling startup calls and added proactive runtime requirements for chunks. [1] [2] [3]Startup Chunk Dependencies Adjustments:
packages/enhanced/src/lib/startup/MfStartupChunkDependenciesPlugin.ts
: Added additional runtime requirements at both the tree and chunk levels, and customized the startup generation based on entry modules. [1] [2] [3] [4] [5] [6] [7]Miscellaneous Changes:
apps/modernjs/project.json
: Corrected theoptions
field indentation for thebuild
andserve
targets. [1] [2]package.json
: Added the--skip-nx-cache
option to theapp:manifest:dev
script.packages/enhanced/test/ConfigTestCases.basictest.js
: Added a basic test case forConfigTestCases
.Related Issue
Types of changes
Checklist