WIP: allow errorLoadRemote hook catch remote entry resource loading error #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
danpeen
changed the title
🦋 Changeset detectedLatest commit: 0d393fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danpeen
changed the title
danpeen
changed the title
zhoushaw
reviewed
Feb 5, 2025
| @@ -129,6 +167,16 @@ const App = () => { | |||
| path="/remote1/*" | |||
| Component={() => ( | |||
| <Remote1App name={'Ming'} age={12} ref={ref} basename="/remote1" /> | |||
| // <Remote1AppWithErrorBoundary | |||
zhoushaw
reviewed
Feb 5, 2025
| return { | ||
| name: 'fallback-plugin', | ||
| async errorLoadRemote(args) { | ||
| // if (args.lifecycle === 'onLoad') { |
There was a problem hiding this comment.
You can simply delete redundant comments
danpeen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: allow errorLoadRemote hook can catch remote entry resource loading error.
releated issue: #3452
Related Issue
Types of changes
Checklist