-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(enhanced): remove resolve replacements #3236
Conversation
🦋 Changeset detectedLatest commit: f21aca1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Here is a concise summary of the pull request:
This pull request removes the resolution of the runtime path with the .esm.mjs
extension when the federation runtime is set to "hoisted" mode. This simplifies the runtime path handling and ensures that the correct runtime path is used in the application, improving the overall reliability and maintainability of the codebase.
File Summaries
File | Summary |
---|---|
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts | The code changes remove the replacement of the runtime path with the .esm.mjs extension when the federation runtime is set to "hoisted" mode. This simplifies the runtime path handling and ensures that the correct runtime path is used in the application. |
f430834
to
f21aca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incremental Review
Comments posted: 1
Configuration
Squadron Mode: essential
Commits Reviewed
4c9f72526b45f76ebcaea4eeb4a51434300a0940...f21aca1b4a7acd136ca6d37c61fecdda31572e10
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/thick-baboons-hear.md
Description
This pull request removes the resolution of the runtime path with the .esm.mjs extension when the federation runtime is set to "hoisted" mode. This simplifies the runtime path handling and ensures that the correct runtime path is used in the application, improving the overall reliability and maintainability of the codebase.
Related Issue
#3210
Types of changes
Checklist