-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve transform configs on sdk #2643
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
143338b
to
af40bd6
Compare
af40bd6
to
35f347d
Compare
# Conflicts: # .github/workflows/build-and-test.yml
# Conflicts: # .github/workflows/build-and-test.yml
# Conflicts: # .github/workflows/build-and-test.yml
Co-authored-by: Matteo Pietro Dazzi <[email protected]>
@zhoushaw should we rather pass a flag from user options to enable crossorigin attribute or if user implements manifest then we enable cross origin? |
# Conflicts: # apps/3000-home/next.config.js # apps/3000-home/pages/_app.tsx # apps/3001-shop/next.config.js # apps/3001-shop/pages/_app.tsx # apps/3002-checkout/next.config.js # apps/3002-checkout/pages/_app.tsx
bc96f53
to
34abe46
Compare
34abe46
to
31a12b8
Compare
Description
If CORS headers are not set the application will fail to load remotes with crossorigin=anonymous
As fallback, attempt to inject script without cors tags
Related Issue
Types of changes
Checklist