Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Documentation Refactoring & New Doc Topics #2195

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

omfgnuts
Copy link
Contributor

Types of changes

  • Docs change / refactoring / dependency upgrade

@zhoushaw
Copy link
Collaborator

zhoushaw commented Mar 19, 2024

We are reconstructing the new version of the document. The content and structure of the document will change greatly. This mr Is temporarily closed

@zhoushaw zhoushaw closed this Mar 19, 2024
@omfgnuts
Copy link
Contributor Author

Heyo @zhoushaw, I noticed my pull request for the Module Federation documentation was closed.

I wanted to clarify that the documentation I submitted is intended for the main section of the Module Federation documentation located on https://module-federation.io/, for which I am the sole maintainer. The closure seems to have been a mix-up, thinking it was for a different part of the repository (?).

Could you please review it once more? Also, I'd like to know about the plans to update or expand the documentation, as you noted in your reply—I'm eager to contribute further!

@zhoushaw zhoushaw reopened this Mar 20, 2024
@zhoushaw
Copy link
Collaborator

zhoushaw commented Mar 20, 2024

Thanks for your explanation, this change of yours will be merged. Here are the changes to be made in our new version document, which is still under construction at present. I will initiate merge request when I finish writing the basic part #2207

@zhoushaw zhoushaw merged commit 1809666 into module-federation:main Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants