fix(bridge-react): prevent react-dom/client being bundled into dist/i…

…ndex.*.js this otherwise causes the package to be incompatible with a react 19 BREAKING CHANGE: react-dom/client code will not be bundled into the bridge-react module anymore
module-federation · Feb 4, 2025 · f29b319 · f29b319
1 parent f141396
commit f29b319
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.changeset/chilly-zoos-collect.md b/.changeset/chilly-zoos-collect.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/bridge-react': patch
+---
+
+change rollup config to prevent react-dom/client code being bundled into the bridge-react package
diff --git a/packages/bridge/bridge-react/vite.config.ts b/packages/bridge/bridge-react/vite.config.ts
@@ -33,6 +33,7 @@ export default defineConfig({
       external: [
         ...perDepsKeys,
         '@remix-run/router',
+        /react-dom\/.*/,
         'react-router',
         'react-router-dom/',
         'react-router-dom/index.js',