Skip to content

Commit

Permalink
chore: tes ci installing error
Browse files Browse the repository at this point in the history
  • Loading branch information
danpeen committed Feb 5, 2025
1 parent 8c057aa commit ae09b59
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 22 deletions.
3 changes: 1 addition & 2 deletions apps/router-demo/router-host-2000/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"@module-federation/retry-plugin": "workspace:*",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router-dom": "^6.24.1",
"react-error-boundary": "5.0.0"
"react-router-dom": "^6.24.1"
},
"devDependencies": {
"@module-federation/rsbuild-plugin": "workspace:*",
Expand Down
16 changes: 8 additions & 8 deletions apps/router-demo/router-host-2000/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import Detail from './pages/Detail';
import Home from './pages/Home';
import './App.css';
import BridgeReactPlugin from '@module-federation/bridge-react/plugin';
import { ErrorBoundary } from 'react-error-boundary';
// import { ErrorBoundary } from 'react-error-boundary';
// import Remote1AppNew from 'remote1/app';
import type { FederationRuntimePlugin } from '@module-federation/enhanced/runtime';

Expand Down Expand Up @@ -79,13 +79,13 @@ const Remote1App = createRemoteComponent({
});

const Remote1AppWithLoadRemote = React.lazy(() => loadRemote('remote1/app'));
const Remote1AppWithErrorBoundary = React.forwardRef<any, any>((props, ref) => (
<ErrorBoundary fallback={<div>Error loading Remote1App...</div>}>
<Suspense fallback={<div> Loading Remote1App...</div>}>
<Remote1AppWithLoadRemote {...props} ref={ref} />
</Suspense>
</ErrorBoundary>
));
// const Remote1AppWithErrorBoundary = React.forwardRef<any, any>((props, ref) => (
// <ErrorBoundary fallback={<div>Error loading Remote1App...</div>}>
// <Suspense fallback={<div> Loading Remote1App...</div>}>
// <Remote1AppWithLoadRemote {...props} ref={ref} />
// </Suspense>
// </ErrorBoundary>
// ));

const Remote2App = createRemoteComponent({
loader: () => import('remote2/export-app'),
Expand Down
14 changes: 2 additions & 12 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ae09b59

Please sign in to comment.