fix: order issue

module-federation · Jan 21, 2025 · 941401c · 941401c
1 parent 8d84222
commit 941401c
Showing 1 changed file with 10 additions and 18 deletions.
diff --git a/packages/dts-plugin/src/plugins/GenerateTypesPlugin.ts b/packages/dts-plugin/src/plugins/GenerateTypesPlugin.ts
@@ -92,12 +92,11 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
     const emitTypesFiles = async (compilation: Compilation) => {
       // Dev types will be generated by DevPlugin, the archive filename usually is dist/.dev-server.zip
       try {
-        await consumeTypesPromise;
-
         const { zipTypesPath, apiTypesPath, zipName, apiFileName } =
           retrieveTypesAssetsInfo(finalOptions.remote);
 
         if (isProd && zipName && compilation.getAsset(zipName)) {
+          callback();
           return;
         }
 
@@ -153,19 +152,15 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
               compiler.outputFileSystem.mkdir(
                 path.dirname(zipOutputPath),
                 (err) => {
-                  if (err) {
-                    if (!isEEXIST(err)) {
-                      reject(err);
-                    }
+                  if (err && !isEEXIST(err)) {
+                    reject(err);
                   } else {
                     compiler.outputFileSystem.writeFile(
                       zipOutputPath,
                       zipContent,
                       (writeErr) => {
-                        if (writeErr) {
-                          if (!isEEXIST(writeErr)) {
-                            reject(writeErr);
-                          }
+                        if (writeErr && !isEEXIST(writeErr)) {
+                          reject(writeErr);
                         } else {
                           resolve();
                         }
@@ -188,19 +183,15 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
               compiler.outputFileSystem.mkdir(
                 path.dirname(apiOutputPath),
                 (err) => {
-                  if (err) {
-                    if (!isEEXIST(err)) {
-                      reject(err);
-                    }
+                  if (err && !isEEXIST(err)) {
+                    reject(err);
                   } else {
                     compiler.outputFileSystem.writeFile(
                       apiOutputPath,
                       apiContent,
                       (writeErr) => {
-                        if (writeErr) {
-                          if (!isEEXIST(writeErr)) {
-                            reject(writeErr);
-                          }
+                        if (writeErr && !isEEXIST(writeErr)) {
+                          reject(writeErr);
                         } else {
                           resolve();
                         }
@@ -231,6 +222,7 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
             compilation.constructor.PROCESS_ASSETS_STAGE_OPTIMIZE_TRANSFER,
         },
         async () => {
+          await consumeTypesPromise;
           const emitTypesFilesPromise = emitTypesFiles(compilation);
           if (isProd) {
             await emitTypesFilesPromise;