fix: avoid falsy values or plugin functions in checkSingleton

module-federation · Feb 5, 2025 · 5395d95 · 5395d95
1 parent 81fcc19
commit 5395d95
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/packages/rspack/src/ModuleFederationPlugin.ts b/packages/rspack/src/ModuleFederationPlugin.ts
@@ -1,6 +1,8 @@
 import type {
   Compiler,
+  Falsy,
   ModuleFederationPluginOptions,
+  RspackPluginFunction,
   RspackPluginInstance,
 } from '@rspack/core';
 import {
@@ -48,16 +50,22 @@ export class ModuleFederationPlugin implements RspackPluginInstance {
 
   private _checkSingleton(compiler: Compiler): void {
     let count = 0;
-    compiler.options.plugins.forEach((p: any) => {
-      if (p.name === this.name) {
-        count++;
-        if (count > 1) {
-          throw new Error(
-            `Detect duplicate register ${this.name},please ensure ${this.name} is singleton!`,
-          );
+    compiler.options.plugins.forEach(
+      (p: Falsy | RspackPluginInstance | RspackPluginFunction) => {
+        if (typeof p !== 'object' || !p) {
+          return;
         }
-      }
-    });
+
+        if (p['name'] === this.name) {
+          count++;
+          if (count > 1) {
+            throw new Error(
+              `Detect duplicate register ${this.name},please ensure ${this.name} is singleton!`,
+            );
+          }
+        }
+      },
+    );
   }
 
   apply(compiler: Compiler): void {