Follow up on MODCLUSTER-204 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajik
commented
Jun 7, 2024
jfclere
approved these changes
Jun 10, 2024
It's already on the list #93 :) |
rhusar
requested changes
Jun 10, 2024
|
The last commit improves the warning messages so that they don't get outdated in case we change the macro values again. |
rhusar
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
OK I am going to approve this since we have a Jira that we need to get to the bottom of - https://issues.redhat.com/browse/MODCLUSTER-822
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After MODCLUSTER-204 fix in #234, I've noticed that there's no warning in case of too long context. This adds one & fixes a small off-by-one in printing.