..

NAMESPACE

@@ -56,7 +56,6 @@ importFrom(R6,R6Class)
 importFrom(stats,dnorm)
 importFrom(stats,pnorm)
 importFrom(stats,quantile)
-importFrom(stats,rexp)
 importFrom(stats,runif)
 importFrom(stats,setNames)
 importFrom(utils,bibentry)

R/SurrogateLearner.R

@@ -214,6 +214,7 @@ SurrogateLearner = R6Class("SurrogateLearner",
     # Train learner with new data.
     # Also calculates the insample performance based on the `perf_measure` hyperparameter if `assert_insample_perf = TRUE`.
     .update = function() {
+      xydt = self$archive$data[, c(self$cols_x, self$cols_y), with = FALSE]
       task = TaskRegr$new(id = "surrogate_task", backend = xydt, target = self$cols_y)
       assert_learnable(task, learner = self$learner)
       self$learner$train(task)

tests/testthat/helper.R

@@ -195,3 +195,14 @@ expect_acqfunction = function(acqf) {
   expect_man_exists(acqf$man)
 }
 
+sortnames = function(x) {
+  if (!is.null(names(x))) {
+    x = x[order(names(x), decreasing = TRUE)]
+  }
+  x
+}
+
+expect_equal_sorted = function(x, y, ...) {
+  expect_equal(sortnames(x), sortnames(y), ...)
+}
+

tests/testthat/test_SurrogateLearner.R

@@ -50,7 +50,7 @@ test_that("param_set", {
   inst = MAKE_INST_1D()
   surrogate = SurrogateLearner$new(learner = REGR_FEATURELESS, archive = inst$archive)
   expect_r6(surrogate$param_set, "ParamSet")
-  expect_setequal(surrogate$param_set$ids(), c("assert_insample_perf", "perf_measure", "perf_threshold", "catch_errors", "impute_missings"))
+  expect_setequal(surrogate$param_set$ids(), c("assert_insample_perf", "perf_measure", "perf_threshold", "catch_errors"))
   expect_equal(surrogate$param_set$class[["assert_insample_perf"]], "ParamLgl")
   expect_equal(surrogate$param_set$class[["perf_measure"]], "ParamUty")
   expect_equal(surrogate$param_set$class[["perf_threshold"]], "ParamDbl")