Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project: mkdocs-data-plugin #277

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add project: mkdocs-data-plugin #277

merged 2 commits into from
Nov 22, 2024

Conversation

joapuiib
Copy link
Contributor

What kind of change does this PR introduce?

  • Add a project
  • Update a project
  • Remove a project
  • Add or update a category
  • Change configuration
  • Documentation
  • Other, please describe:

Description:

Checklist:

  • I have read the CONTRIBUTING guidelines.
  • I have not modified the README.md file. Projects are only supposed to be added or updated within the projects.yaml file since the README.md file is automatically generated.

@joapuiib
Copy link
Contributor Author

Closes #276

@joapuiib joapuiib marked this pull request as ready for review November 22, 2024 16:01
@pawamoy
Copy link
Collaborator

pawamoy commented Nov 22, 2024

Thanks! Can you move the new entry at the end of the code-exec-templating category instead of at the end of the file?

@joapuiib
Copy link
Contributor Author

Sure,
I didn't notice it was ordered 😅 🤦🏼‍♂️

@joapuiib
Copy link
Contributor Author

Also, any feedback on the plugin is more than welcome 😄

pawamoy
pawamoy approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@pawamoy pawamoy merged commit 4466220 into mkdocs:main Nov 22, 2024
1 check passed
@joapuiib
Copy link
Contributor Author

Looking again at the categories, I might have rushed setting it to 🤖 Code execution, variables & templating

Maybe it would be better suited in 📁 Snippets & includes (reusing contents)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joapuiib @pawamoy