fix authentication incomplete case of authentication handler

mittwald · Aug 8, 2023 · afd2b80 · afd2b80
1 parent 8409ac8
commit afd2b80
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/auth/rest.go b/auth/rest.go
@@ -225,11 +225,12 @@ func (a *RestAuthDecorator) RegisterRoutes(mux *httprouter.Router) error {
 				rw.WriteHeader(403)
 				_, _ = rw.Write([]byte(`{"msg":"invalid credentials"}`))
 				return
-			} else if errors.Is(err, &AuthenticationIncompleteError{}) {
-				if err = handleIncompleteAuthentication(err.(*AuthenticationIncompleteError), rw); err != nil {
-					handleError(err, rw)
+			} else if errors.Is(err, AuthenticationIncompleteError{}) {
+				if innerErr := handleIncompleteAuthentication(err.(*AuthenticationIncompleteError), rw); innerErr != nil {
+					handleError(innerErr, rw)
 					return
 				}
+				return
 			} else if err != nil || authResponse == nil {
 				handleError(err, rw)
 				return