Introduce "sync-by-content" flag, implemented for secrets and configmaps #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optionally ignore the "replicated-from-version" annotation and always compare by contents - Implemented for secrets and config maps - Add test for secrets for the new feature - Change secret tests to use fake.Clientset instead of running in whatever happened to be your active KUBECONFIG(!)
stippi2
changed the title
martin-helmich
previously approved these changes
Nov 5, 2024
martin-helmich
approved these changes
Nov 6, 2024
|
@martin-helmich Many thanks for merging!! Is a new release automatically triggered and I just have to be patient? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this flag is enabled, the replicator will ignore the
replicated-from-versionannotation and always compare the contents of the target object to the source object and keep them in sync.Fixes #349 for secrets and configmaps