add subTitle to extension #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdellmann
force-pushed
the
subtitle
branch
3 times, most recently
from
87de30a to
2cd292f
Compare
freisenhauer
reviewed
Feb 3, 2025
| required: ["de"], | ||
| properties: { | ||
| de: { | ||
| type: "string", |
There was a problem hiding this comment.
Information about max length is missing here (and in the other places)
| @@ -41,6 +42,21 @@ For more information about the individual attributes, see [which information an | |||
| description: "Name of the extension", | |||
| example: "Example Extension", | |||
| }, | |||
| subTitle: { | |||
| type: "object", | |||
| description: "A brief description of the extension", | |||
There was a problem hiding this comment.
now we have a short description and a brief description.
We should clarify the purpose in the description of the fields.
freisenhauer
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.