Refactor utreexo/cmd/ #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything is refactored. While reviewing code to do the TODOs mentioned in mit-dci#79, I noticed some things to clean up. This refactor is needed for the goals mentioned in mit-dci#79 as it separates 1. Bridge node and CSN (Compact State Node) 2. Chain resume functionality from both bridgenode and csn (placed in chain.go and chainio.go in both bridgenode/ and csn/ Changed things 1. All functionality for store and restore to disk is now placed in chain.go and chainio.go in both bridgenode/ and csn/ 2. Various bugs involving offsetfile.go was fixed. To add new blocks from blk*.dat files, all the user has to do is delete the offsetdata directory and re-run genproofs to rebuild the offset index. Both genproofs and ibdsim will resume where they left off and sync the new blocks. 3. main.go file in directory cmd/ is the main file now. 4. Separated all ttl related things to its own directory. 5. Removed all names related or implying a simulator. 6. Various comment cleanups
kcalvinalvin
force-pushed
the
check-block-2
branch
from
d487ded to
2e01f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything in
utreexo/cmd/is refactored.While reviewing code to do the TODOs mentioned in #79, I noticed some things to clean up.
This refactor is needed for the goals mentioned in #79 as it separates
chain.goandchainio.goin bothbridgenode/andcsn/Changed things
All functionality for store and restore to disk is now placed in
chain.goandchainio.goin bothbridgenode/andcsn/Various bugs involving offsetfile.go was fixed. To add new blocks from
blk*.datfiles, all the user has to do is delete theoffsetdatadirectory and re-rungenproofsto rebuild the offset index. Bothgenproofsandibdsimwill resume where they left off and sync the new blocks.main.gofile in directorycmd/is the main file now.Separated all ttl related things to its own directory.
Updated
readme.mdinutreexo/cmd/and inutreexo/Removed all names related or implying a simulator.
Various comment cleanups in all files