Add CLI arguments to build.sh, specify build type #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurermi
added
the
enhancement/build-system
rockett-m
reviewed
Apr 11, 2024
rockett-m
reviewed
Apr 11, 2024
rockett-m
reviewed
Apr 11, 2024
rockett-m
reviewed
Apr 11, 2024
rockett-m
reviewed
Apr 11, 2024
maurermi
force-pushed
the
modify_build_script
branch
from
5b39449 to
c602e8b
Compare
HalosGhost
reviewed
Apr 18, 2024
maurermi
force-pushed
the
modify_build_script
branch
from
c602e8b to
d734242
Compare
|
@HalosGhost @rockett-m Made some updates to address review comments, would love another look over if possible! |
Adds CLI arguments to build.sh, and prints to stdout the type of build being performed. Default build is still Debug. Additonally supports a BUILD_DEBUG environment variable, and respects previously set values of CMAKE_BUILD_TYPE. Add in help function Signed-off-by: Michael Maurer <[email protected]>
maurermi
force-pushed
the
modify_build_script
branch
from
d734242 to
1c80ead
Compare
HalosGhost
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
tACK. Does what it says on the tin; allow specifying build-type as a basic command-line argument.
Purely positional, but still much more pleasant than having to use environment variables; and interacts cleanly with env-vars so no tooling should break (cleanly allowing cli args to override env-vars as-typical).
LGTM. Merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CLI arguments to build.sh, and prints to stdout the type of build being performed. Default build is still Debug. Additonally supports a BUILD_DEBUG environment variable, and respects previously set values of CMAKE_BUILD_TYPE.
Low urgency - I found this useful and hopefully others will.