Only show those channels whose daemons are running #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we update this PR? I would like these channels to be shown in a separate category "Disabled channels" when you do Another thought: When trying to use these channels (since they still have an id someone could do |
|
Closing this PR since lots of changes have been made to ls since the PR was made. Lets continue this conversation in your PR :) |
|
Created #337 to track the idea for rejecting updates on "disabled" channels. Will open new PR for the LS output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to show these channels since this causes confusion and people would be like "why is this channel unconfirmed" when in reality its another channel which had a bug due to insufficient funding or something.