-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add node-chakracore to CI testing #3087
Open
alexlamsl
wants to merge
1
commit into
mishoo:master
Choose a base branch
from
alexlamsl:travis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad274f1
to
70490f8
Compare
fc31b78
to
6cb75d1
Compare
3447f25
to
8b8e12c
Compare
aba2c53
to
b02cc82
Compare
7d1c0a7
to
b468103
Compare
2c87831
to
18af827
Compare
e5231c5
to
04974ea
Compare
57c7752
to
4833362
Compare
46feb12
to
eab8b17
Compare
a682f68
to
65ddb92
Compare
9e33b29
to
6636387
Compare
cf2d9c0
to
bc82694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showstoppers:
vm.runInNewContext()
nodejs/node-chakracore#478Object.create(null)
nodejs/node-chakracore#508[].push.apply([], a)
results in "Out of stack space" nodejs/node-chakracore#521