-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/41 renv rsconnect updates #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuidoMaggio, the workflows are no fully up-to-date with ShinyCICD
When porting updates done and tested in ShinyCICD to the techguides, I would always try to get in ShinyCICD the workflows from the techguides to verify we have full consistency, via
usethis::use_github_file("miraisolutions/techguides", ref="feature/41-renv-rsconnect-updates",path="shiny-ci-cd/actions/ci-cd.yml", save_as = "shiny-ci-cd/actions/ci-cd.yml")
usethis::use_github_file("miraisolutions/techguides", ref="feature/41-renv-rsconnect-updates",path="shiny-ci-cd/actions/ci-cd-renv.yml", save_as = "shiny-ci-cd/actions/ci-cd-renv.yml")
Also deploy-shinyapps.io
lacks some of the refinements we did in ShinyCICD
(NOTE: we cannot use usethis::use_github_action()
, as we have in the techguides for a branch that contains "/").
deploy update
@riccardoporreca I have added 'renv' instead of 'release' in the -renv.yml. Here I did not spot other differences with ShinyCICD.
The code above works well to me |
There is more in both cases that we want to have. Maybe it is easier for me to take over, since some of the changes should probably be explained in the techguides as part of this content refresh. @GuidoMaggio let's coordinate on this. Btw, in the past I actually pulled in the full files from ShinyCICD to avoid manual pasting and have more traceability, see 24798ad => UPDATE: I have started to commit the complete workflow files, see c8fde8b |
* `schedule`/`concurrency` removed (specific to ShinyCICCD maintenance) * changes ported to the CI-only Based on ```r usethis::use_github_file( "miraisolutions/ShinyCICD", ref = "842b40b6e5790fae3a2ed36ce2ec147b77f90fd8", ".github/workflow/ci-cd.yml", "shiny-ci-cd/actions/ci-cd.yml" ) usethis::use_github_file( "miraisolutions/ShinyCICD", ref = "842b40b6e5790fae3a2ed36ce2ec147b77f90fd8", ".github/workflows/ci-cd-renv.yml", "shiny-ci-cd/actions/ci-cd-renv.yml" ) ```
```r usethis::use_github_file( "miraisolutions/ShinyCICD", ref = "842b40b6e5790fae3a2ed36ce2ec147b77f90fd8", "deploy/deploy-shinyapps.R", "shiny-ci-cd/deploy/deploy-shinyapps.R" ) ```
* Since `master` is the legacy pre-v2 branch
@GuidoMaggio, I have pushed my updates and general review of the Shiny CI/CD chapter. I plan to do the same for the renv chapter |
@GuidoMaggio, @RolandASc, I ended up doing a major review and partial re-write/restructuring of the |
@GuidoMaggio, this is complete from my side, please cross-review the changes I did |
Followed-up directly by committing to the branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 changes requested
Unintentionaly committed as "implicit" Co-authored-by: Guido Maggio <[email protected]>
ok Co-authored-by: Riccardo Porreca <[email protected]>
Update of renv chapter. See also #41
snapshot.type = "explicit" / "implicit"
options(repos = "https://packagemanager.rstudio.com/cran/2023-01-02")
works to fix the date of the repo, like MRAN was working previously. tested.renv::snapshot(dev = TRUE)
renv::status
renv::checkout()
I have tested the usage of
renv::checkout(date = , repos = )
andoptions(repo = )
. Also checkout is then setting the new repo to the date specified (or to the repos url).I.e.
renv::checkout(date = "2023-01-01" )
would then set alsooptions(repos = "https://packagemanager.rstudio.com/cran/2023-01-01")
.Checkout has more options, packages can be installed, or only a snapshot of the
renv.lock
can be done.Update of CI-CD chapter.
forceUpdate = TRUE
torsconnect::deployApp