Remove deprecated var.defaults and var.private #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariux
requested changes
Nov 8, 2022
Comment on lines
+10
to
+14
| ### Removed | ||
|
|
||
| - BREAKING CHANGE: Removed deprecated `var.defaults` | ||
| - BREAKING CHANGE: Removed deprecated `var.private`, use `var.visibility` instead | ||
|
|
There was a problem hiding this comment.
no need to remove them already unless we refactor the complete module.
There was a problem hiding this comment.
The problem is that the module is barely maintainable due to the complexity of defaults. I'd still like to merge this PR, migrate to the new test suite as a next step and then start adding more features requested by the community. WDYT?
There was a problem hiding this comment.
new feature do not need to be added to the complex defaults.. this module is on the list of complete refactor. There is no need to add breaking changes now.
soerenmartius
force-pushed
the
soerenmartius/remove-deprecated-variables
branch
6 times, most recently
from
a1f07ac to
be924ff
Compare
soerenmartius
force-pushed
the
soerenmartius/remove-deprecated-variables
branch
from
be924ff to
af7c39f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.