Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not add a context #129

Closed
wants to merge 8 commits into from
Closed

do not add a context #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fc78e4a
do not add a context
mariux Sep 13, 2022
ae3ba79
fix: downgrade provider
mariux Sep 13, 2022
a071331
fix: projects in default test
mariux Sep 13, 2022
58cb1a8
fix: test
mariux Sep 13, 2022
6088e16
test: update provider
mariux Sep 13, 2022
0150c2a
test: update provider
mariux Sep 13, 2022
ff4baac
test: downgrade provider
mariux Sep 13, 2022
7b2dedc
test: remove context
mariux Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ resource "github_branch_protection_v3" "branch_protection" {
for_each = local.required_status_checks[count.index]

content {
strict = required_status_checks.value.strict
contexts = required_status_checks.value.contexts
strict = required_status_checks.value.strict
# contexts = required_status_checks.value.contexts
}
}

Expand Down
9 changes: 5 additions & 4 deletions test/unit-complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ module "repository" {
homepage_url = var.url
private = false
has_issues = var.has_issues
has_projects = var.has_projects
has_projects = true
has_wiki = var.has_wiki
allow_merge_commit = var.allow_merge_commit
allow_rebase_merge = var.allow_rebase_merge
Expand Down Expand Up @@ -94,8 +94,7 @@ module "repository" {
require_signed_commits = true

required_status_checks = {
strict = true
contexts = ["ci/travis"]
strict = true
}

required_pull_request_reviews = {
Expand Down Expand Up @@ -129,7 +128,7 @@ module "repository" {
tls_private_key.deploy[1].public_key_openssh
]

projects = var.projects
projects = []

autolink_references = var.autolink_references

Expand All @@ -150,6 +149,8 @@ module "repository-with-defaults" {
defaults = var.repository_defaults
default_branch = "development"

projects = []

branches = [
{ name = "development" },
]
Expand Down
2 changes: 1 addition & 1 deletion test/unit-complete/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ terraform {
required_providers {
github = {
source = "integrations/github"
version = "~> 4.19"
version = "4.25"
}
tls = "~> 2.1"
}
Expand Down