Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of var.app_installations #123

Merged
merged 2 commits into from
May 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.16.2]

### Fixed

- `var.app_installations` should be a of type `set(string)` instead of `set(number)`

## [0.16.1]

### Added
Expand Down Expand Up @@ -374,7 +380,8 @@ Please review plans and report regressions and issues asap so we can improve doc
- This is the initial release of our GitHub Repository module with support for
creating and managing GitHub Repositories for Organizations.

[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.1...HEAD
[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.2...HEAD
[0.16.2]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.1...v0.16.2
[0.16.1]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.0...v0.16.1
[0.16.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.15.0...v0.16.0
[0.15.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.14.0...v0.15.0
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ This is due to some terraform limitation and we will update the module once terr

#### App Installations

- [**`app_installations`**](#var-app_installations): *(Optional `set(number)`)*<a name="var-app_installations"></a>
- [**`app_installations`**](#var-app_installations): *(Optional `set(string)`)*<a name="var-app_installations"></a>

A set of GitHub App IDs to be installed in this repository.

Expand All @@ -820,7 +820,7 @@ This is due to some terraform limitation and we will update the module once terr
Example:

```hcl
app_installations = [25405144, 12556423]
app_installations = ["05405144", "12556423"]
```

### Module Configuration
Expand Down
4 changes: 2 additions & 2 deletions README.tfdoc.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -1057,14 +1057,14 @@ section {
title = "App Installations"

variable "app_installations" {
type = set(number)
type = set(string)
default = {}
description = <<-END
A set of GitHub App IDs to be installed in this repository.
END

readme_example = <<-END
app_installations = [25405144, 12556423]
app_installations = ["05405144", "12556423"]
END
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/unit-complete/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ variable "autolink_references" {
}

variable "app_installations" {
type = set(number)
type = set(string)
description = "A list of GitHub App IDs to be installed in this repository."
default = []
}
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ variable "archive_on_destroy" {
}

variable "app_installations" {
type = set(number)
type = set(string)
description = "(Optional) A list of GitHub App IDs to be installed in this repository."
default = []
}
Expand Down