-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for github_branches #111
Conversation
4672cde
to
f7831f0
Compare
f7831f0
to
32c22f8
Compare
32c22f8
to
5785a39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few possible fixes on docs
@@ -317,8 +318,10 @@ section { | |||
default = "" | |||
description = <<-END | |||
The name of the default branch of the repository. | |||
NOTE: This can only be set after a repository has already been created, and after a correct reference has been created for the target branch inside the repository. | |||
This means a user will have to omit this parameter from the initial repository creation and create the target branch inside of the repository prior to setting this attribute. | |||
NOTE: The configured default branch must exist in the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice ❤️
166bf1e
to
2eb5cdc
Compare
2eb5cdc
to
a09a0c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments :-)
Co-authored-by: Tiago Cesar Katcipis <[email protected]> Update README.tfdoc.hcl Co-authored-by: Tiago Cesar Katcipis <[email protected]>
a09a0c3
to
1debcb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Adds support for the github_branch resource as requested in #107