Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for github_branches #111

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Conversation

soerenmartius
Copy link
Member

@soerenmartius soerenmartius commented Mar 5, 2022

Adds support for the github_branch resource as requested in #107

@soerenmartius soerenmartius force-pushed the soerenmartius/github-branches branch 5 times, most recently from 4672cde to f7831f0 Compare March 5, 2022 06:28
@soerenmartius soerenmartius marked this pull request as ready for review March 5, 2022 06:29
@soerenmartius soerenmartius requested review from mariux and a team as code owners March 5, 2022 06:29
@soerenmartius soerenmartius force-pushed the soerenmartius/github-branches branch from f7831f0 to 32c22f8 Compare March 9, 2022 10:00
@soerenmartius soerenmartius requested review from kassianh and a team March 9, 2022 10:01
kassianh
kassianh previously approved these changes Mar 9, 2022
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few possible fixes on docs

@@ -317,8 +318,10 @@ section {
default = ""
description = <<-END
The name of the default branch of the repository.
NOTE: This can only be set after a repository has already been created, and after a correct reference has been created for the target branch inside the repository.
This means a user will have to omit this parameter from the initial repository creation and create the target branch inside of the repository prior to setting this attribute.
NOTE: The configured default branch must exist in the repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice ❤️

@soerenmartius soerenmartius force-pushed the soerenmartius/github-branches branch 2 times, most recently from 166bf1e to 2eb5cdc Compare March 10, 2022 16:20
@soerenmartius soerenmartius force-pushed the soerenmartius/github-branches branch from 2eb5cdc to a09a0c3 Compare March 10, 2022 16:25
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments :-)

soerenmartius and others added 3 commits March 10, 2022 17:36
Co-authored-by: Tiago Cesar Katcipis <[email protected]>

Update README.tfdoc.hcl

Co-authored-by: Tiago Cesar Katcipis <[email protected]>
@soerenmartius soerenmartius force-pushed the soerenmartius/github-branches branch from a09a0c3 to 1debcb2 Compare March 10, 2022 16:36
@soerenmartius soerenmartius requested a review from katcipis March 10, 2022 16:39
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@soerenmartius soerenmartius merged commit 3bb3764 into main Mar 10, 2022
@soerenmartius soerenmartius deleted the soerenmartius/github-branches branch March 10, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants