Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wavelet using generic numpy/cupy functions #31

Closed
wants to merge 0 commits into from

Conversation

sidward
Copy link
Collaborator

@sidward sidward commented Nov 8, 2019

This is preliminary code to address issue #25. I have not modified any other functions yet as I wanted to run this by you first. The main goal of this commit is to use PyWavelet's wavelet coefficients to perform n-dimensional forward and inverse wavelet transforms using generic numpy/cupy functions. This should hopefully allow for wavelet to be used directly on the GPU. (I have not tested this on the GPU yet, but will be soon.) The main question I wanted to ask is the following: To ease n-dimensional processing, fwt returns a dictionary that iwt takes as input. Is this okay?

@sidward
Copy link
Collaborator Author

sidward commented Nov 8, 2019

Just verified that it runs on the GPU!

@sidward
Copy link
Collaborator Author

sidward commented Nov 8, 2019

If this looks okay to you, I'll:

  1. Edit the iwt documentation in the function to reflect the dictionary input.
  2. Update linop.py and related functions to use the dictionary.
  3. Write unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant