Scrollbar for File menu is displaying over Open Recent

[g122622]

fix #174350

This PR fixes Issue #236982 : Scrollbar for File menu is displaying over Open Recent

Overview

This is not just an issue with the "Open Recent" menu; in fact, it's a common problem for all submenus that have a vertical scrollbar. It is caused by the submenu having too low of a z-index value.

Changes

• The special zIndex = '1' specification for the submenu wrapper element (div.monaco-submenu) has been removed from the src\vs\base\browser\ui\menu\menu.ts file, leaving its z-index still subject to the z-index of 2000 defined in menubar.css.

Modified Files

• src\vs\base\browser\ui\menu\menu.ts

Testing

I have used my own project to test out this feature

Before this fix:

After this fix:

[bpasero]

@g122622 that specific zIndex was added for #103170, are you sure that issue is still resolved after your change?

[g122622]

@bpasero Now I have made further modifications to menu.ts, moving the zIndex=1 to Shadow DOM CSS. As a result, both of these issues are now resolved.

Issue #236982 :

Issue #103170 :

[bpasero]

Thanks, this indeed seems to address the original issue as well as to fix #174350.

I am asking @benibenj for a second look but otherwise I am OK to merge this in. Thanks!