Add node as npm script runner #236967
Draft
Add node as npm script runner #236967
+197
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymopen
force-pushed
the
main
branch
4 times, most recently
from
c5cd0cc to
c1aadd8
Compare
connor4312
reviewed
Jan 7, 2025
| const scriptRunner = await getScriptRunner(folder, context, showWarning); | ||
| const result = [scriptRunner, scriptRunner === 'node' ? '--run' : 'run']; | ||
| if (workspace.getConfiguration('npm', folder).get<boolean>('runSilent')) { | ||
| result.push('--silent'); |
There was a problem hiding this comment.
--silent will cause an error if the scriptRunner is node, we should ignore that setting in this case
| @@ -104,49 +103,61 @@ function isTestTask(name: string): boolean { | |||
| } | |||
| return false; | |||
| } | |||
| const preScripts: Set<string> = new Set([ | |||
| 'est', /* test typo? */ 'install', 'pack', 'pack', 'publish', 'restart', | |||
There was a problem hiding this comment.
Probably a typo, you can fix it :)
Comment on lines
+124
to
+125
| export async function getScriptRunner(folder: Uri, context?: ExtensionContext, showWarning?: boolean): Promise<string> { | ||
| let scriptRunner = workspace.getConfiguration('npm', folder).get<string>('scriptRunner', 'npm'); |
There was a problem hiding this comment.
I think the default in get here should be auto, and if it's auto then we return getPackageManager(...)
| } | ||
| } | ||
| } | ||
| } | ||
| return allTasks; | ||
| } catch (error) { |
There was a problem hiding this comment.
Not sure why it was added initially, but this catch is a no-op, you can remove the try/catch if you want
| const { name, multipleLockFilesDetected: multiplePMDetected } = await findPreferredPM(folder.fsPath); | ||
| const neverShowWarning = 'npm.multiplePMWarning.neverShow'; | ||
| if (showWarning && multiplePMDetected && extensionContext && !extensionContext.globalState.get<boolean>(neverShowWarning)) { | ||
| // todo: add text for npm.scriptRunner? |
There was a problem hiding this comment.
I think we're okay with this text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234468