Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pack conpty binaries into asar #225037

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Don't pack conpty binaries into asar #225037

merged 1 commit into from
Aug 7, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 7, 2024

Part of #224488

@Tyriar Tyriar added this to the August 2024 milestone Aug 7, 2024
@Tyriar Tyriar self-assigned this Aug 7, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Aug 7, 2024

Verified in https://monacotools.visualstudio.com/Monaco/_build/results?buildId=286978&view=results that the binaries are in the archive

@Tyriar Tyriar marked this pull request as ready for review August 7, 2024 12:34
@Tyriar Tyriar enabled auto-merge August 7, 2024 12:34
@Tyriar Tyriar merged commit 72a4296 into main Aug 7, 2024
39 checks passed
@Tyriar Tyriar deleted the tyriar/conpty_asar branch August 7, 2024 13:46
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants