chat overlay tweaks (#237395)

* don't disable accept/reject when having no changes (it's confusing) * add drop shadow
microsoft · Jan 7, 2025 · 9289e2b · 9289e2b
1 parent 4fc21e1
commit 9289e2b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/vs/workbench/contrib/chat/browser/chatEditorActions.ts b/src/vs/workbench/contrib/chat/browser/chatEditorActions.ts
@@ -126,7 +126,7 @@ abstract class AcceptDiscardAction extends Action2 {
 				? localize2('accept2', 'Accept')
 				: localize2('discard2', 'Discard'),
 			category: CHAT_CATEGORY,
-			precondition: ContextKeyExpr.and(ctxHasRequestInProgress.negate(), hasUndecidedChatEditingResourceContextKey, ContextKeyExpr.or(ctxHasEditorModification, ctxNotebookHasEditorModification)),
+			precondition: ContextKeyExpr.and(ctxHasRequestInProgress.negate(), hasUndecidedChatEditingResourceContextKey),
 			icon: accept
 				? Codicon.check
 				: Codicon.discard,

diff --git a/src/vs/workbench/contrib/chat/browser/media/chatEditorOverlay.css b/src/vs/workbench/contrib/chat/browser/media/chatEditorOverlay.css
@@ -12,6 +12,7 @@
 	display: flex;
 	align-items: center;
 	z-index: 10;
+	box-shadow: 0 2px 8px var(--vscode-widget-shadow);
 }
 
 .chat-editor-overlay-widget .chat-editor-overlay-progress {