Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test suite and converting the existing test files to the new test suite #35

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

romainmenke
Copy link
Contributor

@romainmenke romainmenke commented Dec 11, 2024

fixes: #8

This is based on #25
But all changes to grammars/css.cson from that branch have been reverted to ensure that we add tests first, before making changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've converted the previous test suite from coffeescript to plain JavaScript.
This should make it more approachable for others to add and update tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutations:

  • CoffeeScript -> JavaScript
  • node:test as the test runner
  • node:assert as the assertion lib

There are 7 failing test cases.
I've skipped these for now with .skip

@romainmenke romainmenke marked this pull request as ready for review December 11, 2024 12:24
@romainmenke romainmenke changed the title add a test suite Add a test suite and converting the existing test files to the new test suite Dec 11, 2024
@romainmenke
Copy link
Contributor Author

@aeschli, @andreamah could you take a look at this proposed change when you have time please? 🙇 Thank you in advance.

@romainmenke
Copy link
Contributor Author

@aeschli Sorry to keep pinging you on this and please do forward if someone else should follow up. I just happen to know that you also work on https://github.com/microsoft/vscode-css-languageservice.

What would be the best way to make progress on this issue and to start making regular improvements to this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuilding a test suite for this package
2 participants