-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test suite and converting the existing test files to the new test suite #35
base: main
Are you sure you want to change the base?
Add a test suite and converting the existing test files to the new test suite #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've converted the previous test suite from coffeescript to plain JavaScript.
This should make it more approachable for others to add and update tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mutations:
- CoffeeScript -> JavaScript
node:test
as the test runnernode:assert
as the assertion lib
There are 7 failing test cases.
I've skipped these for now with .skip
@aeschli, @andreamah could you take a look at this proposed change when you have time please? 🙇 Thank you in advance. |
@aeschli Sorry to keep pinging you on this and please do forward if someone else should follow up. I just happen to know that you also work on https://github.com/microsoft/vscode-css-languageservice. What would be the best way to make progress on this issue and to start making regular improvements to this package? |
fixes: #8
This is based on #25
But all changes to
grammars/css.cson
from that branch have been reverted to ensure that we add tests first, before making changes.