Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] add dependabot for python, add requirements.txt #5683

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[python] add dependabot for python, add requirements.txt #5683

wants to merge 14 commits into from
+32 −30

Conversation

iscai-msft
Copy link
Member

@iscai-msft iscai-msft commented Jan 21, 2025 •
edited
Loading

@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 21, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

@msyyc msyyc mentioned this pull request Jan 21, 2025
Draft
msyyc
msyyc reviewed Jan 22, 2025
View reviewed changes
packages/http-client-python/generator/requirements.txt Outdated
pathspec==0.12.1
platformdirs==4.3.6
PyYAML==6.0.1
tomli==2.0.1
Copy link
Contributor

@msyyc msyyc Jan 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these dependencies are already declared in setup.py, we removed this file in https://github.com/microsoft/typespec/pull/5445/files to reduce maintenance effort caused by that dependencies are declared in multi places. Why do we add this file requirements.txt again?

msyyc
msyyc requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR influence the way to install dependencies for test framework, please also make a PR which contains similar changes in autorest.python repo.

@iscai-msft
Copy link
Member Author

@msyyc there are differences between install_requires and requirements.txt (see stackoverflow here). I think we should reconsider how we're treating setup.py and install_reqs, but I'm ok to peel this out into a separate PR and change it when we migrate to pyproject.toml here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msyyc msyyc msyyc requested changes

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add dependabot for @typespec/http-client-python in typespec repo
4 participants
@iscai-msft @azure-sdk @timotheeguerin @msyyc