[Not Ready] [typespec-vscode] Rename file should rename import #5674
+243
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhongl524
requested review from
RodgeFu,
bterlson,
markcowl,
allenjzhang,
timotheeguerin and
witemple-msft
as code owners
RodgeFu
reviewed
Jan 21, 2025
| @@ -281,6 +281,34 @@ export function getPathComponents(path: string, currentDirectory = "") { | |||
| return pathComponents(path, getRootLength(path)); | |||
| } | |||
|
|
|||
| export function getRelativePathByComparePaths(from: string, to: string): string { | |||
| if (from.length === 0 || to.length === 0 || from === to) { | |||
There was a problem hiding this comment.
the path-util is copied from vscode, we won't change it.
There was a problem hiding this comment.
There is also already a get relative path above
| @@ -85,6 +85,25 @@ export class TspLanguageClient { | |||
| } | |||
| } | |||
|
|
|||
| async updateImportsOnFileMovedOrRenamed( | |||
There was a problem hiding this comment.
can this not be done in the language server?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #2470
Compiler:
Locate the file with the modified import content and modify it
Typespec-vscode:
Add implementation code such as configuration content and user-friendly operations