Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema description #18388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix schema description #18388

wants to merge 1 commit into from

Conversation

Tarang74
Copy link

@Tarang74 Tarang74 commented Jan 3, 2025 •
edited
Loading

Summary of the Pull Request

Fixes typo in experimental.rightClickContextMenu property description. Description should say right-click pastes, rather than copies.

PR Checklist

  • Schema updated

DHowett
DHowett requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so funny enough, the default action for right-click is actually both of those things. it copies if there is a selection or pastes if there is not.

if you can think of a succinct way to cover both of those things, i'd love to approve it!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 6, 2025
@Tarang74
Copy link
Author

Tarang74 commented Jan 6, 2025 •
edited
Loading

interesting! i'll revise the description when i have time this week!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tarang74 @DHowett