Fix Microsoft.Windows.Console.ConPTY package runtime identifiers #18387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugh. an ecosystem that keeps changing like this should be doomed. |
DHowett
approved these changes
Jan 6, 2025
win10-* is no longer a valid rid
mitchcapper
force-pushed
the
fix_winconpty_runtime_id
branch
from
5e9addb to
055061b
Compare
|
I did push an update with the build target file as well, it is the only other place in the entire repo that I see the older runtime style. As for WPF: No, the WPF control doesn't have any hardcoded runtime ids like this for output targets (so it automatically is generating them with the correct path).
|
DHowett
approved these changes
Jan 6, 2025
carlos-zamora
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
win10-* is no longer a valid rid
https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/rid-graph
Summary of the Pull Request
This package would fail to install the dependencies to the correct location in .net 8 and later by default. win-x64 is a valid runtime id in prior .net versions so I think this should be back compat.
Without this the package fails to do its job on newer builds unless
<UseRidGraph>true</UseRidGraph>and the user setswin10-x64as their RID in their project file.