Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bump to Microsoft.Extensions.DependencyModel (Revert part of #847) #851

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

DaveTryon
Copy link
Contributor

PR #847 bumped both Microsoft.Extensions.DependencyModel and System.Text.Json. It passed all local tests and successfully passed the PR checks, but after it merged, it was causing test failures in the CI pipeline. I ran 2 iterations of the CI pipeline, one reverting both version bumps, and one reverting just Microsoft.Extensions.DependencyModel. They both passed. Bumping System.Text.Json is a good thing, so this PR backs out just the bump to Microsoft.Extensions.DependencyModel

@DaveTryon DaveTryon requested a review from a team as a code owner January 4, 2025 03:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.50%. Comparing base (66f405b) to head (7e7d2f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   44.50%   46.50%   +2.00%     
==========================================
  Files         355      355              
  Lines       14142    14142              
  Branches     1161     1161              
==========================================
+ Hits         6294     6577     +283     
+ Misses       7308     7017     -291     
- Partials      540      548       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaveTryon DaveTryon merged commit 3d38ef0 into main Jan 6, 2025
7 checks passed
@DaveTryon DaveTryon deleted the DaveTryon/revert-847-partial branch January 6, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants