refactor: rename legacy control plane to standard and update related scripts and docs #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apontejaj
previously approved these changes
Jan 22, 2025
kamilprz
reviewed
Jan 23, 2025
…allation and configuration documents
ritwikranjan
force-pushed
the
feat/rename-legacy
branch
from
9687cdd to
f7e1475
Compare
Made all doc references of the name with S capital in Standard Co-authored-by: kamilprz <[email protected]> Signed-off-by: Ritwik Ranjan <[email protected]>
kamilprz
approved these changes
Jan 23, 2025
kamilprz
added a commit
to kamilprz/retina
that referenced
this pull request
Jan 24, 2025
…scripts and docs (microsoft#1259) # Description This pull request includes significant changes to transition from the "legacy" to the "standard" directory and package structure. The changes involve updates to Helm charts, Makefile commands, package imports, and file paths. Directory and package structure updates: * [`.github/workflows/release-charts.yaml`](diffhunk://#diff-711012dcc1f315d20ef98e04b14cbc0cb1a388641934c2151ac99f74ff11f62cL43-R43): Updated the Helm package path from `legacy` to `standard`. * [`Makefile`](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L447-R447): Updated multiple Helm install commands to use the `standard` directory instead of `legacy`. [[1]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L447-R447) [[2]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L460-R460) [[3]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L477-R477) [[4]](diffhunk://#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L496-R496) * [`cmd/root.go`](diffhunk://#diff-ab967ab1a2f3a1b769106eeb7bfe892ef0e81d1d27811fa15be08e6749feee1fL9-R9): Changed package imports and daemon initialization from `legacy` to `standard`. [[1]](diffhunk://#diff-ab967ab1a2f3a1b769106eeb7bfe892ef0e81d1d27811fa15be08e6749feee1fL9-R9) [[2]](diffhunk://#diff-ab967ab1a2f3a1b769106eeb7bfe892ef0e81d1d27811fa15be08e6749feee1fL31-R31) * Renamed files from `legacy` to `standard`: * `cmd/legacy/daemon.go` to `cmd/standard/daemon.go` * `cmd/legacy/daemon_linux.go` to `cmd/standard/daemon_linux.go` * `cmd/legacy/daemon_windows.go` to `cmd/standard/daemon_windows.go` * [`crd/Makefile`](diffhunk://#diff-414956f6f35c3bc4a93c4c08592ee22397d76d99a1b728e1e33c65075a2a99c8L7-R7): Updated the `HELM_CRD_DIR` path to use the `standard` directory. File deletions and renames: * Deleted `deploy/legacy/prometheus/retina/create-cm.sh`. * Renamed `deploy/legacy/manifests/controller/helm/retina/templates/NOTES.txt` to `deploy/standard/manifests/controller/helm/retina/templates/NOTES.txt` with updated paths inside the file. ## Related Issue This PR will close microsoft#1115 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Ritwik Ranjan <[email protected]> Co-authored-by: kamilprz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes significant changes to transition from the "legacy" to the "standard" directory and package structure. The changes involve updates to Helm charts, Makefile commands, package imports, and file paths.
Directory and package structure updates:
.github/workflows/release-charts.yaml: Updated the Helm package path fromlegacytostandard.Makefile: Updated multiple Helm install commands to use thestandarddirectory instead oflegacy. [1] [2] [3] [4]cmd/root.go: Changed package imports and daemon initialization fromlegacytostandard. [1] [2]legacytostandard:cmd/legacy/daemon.gotocmd/standard/daemon.gocmd/legacy/daemon_linux.gotocmd/standard/daemon_linux.gocmd/legacy/daemon_windows.gotocmd/standard/daemon_windows.gocrd/Makefile: Updated theHELM_CRD_DIRpath to use thestandarddirectory.File deletions and renames:
deploy/legacy/prometheus/retina/create-cm.sh.deploy/legacy/manifests/controller/helm/retina/templates/NOTES.txttodeploy/standard/manifests/controller/helm/retina/templates/NOTES.txtwith updated paths inside the file.Related Issue
This PR will close #1115
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.