Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retina mode support for perf-test and abstract common e2e setups #1244

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

ritwikranjan
Copy link
Contributor

Description

This pull request includes several changes to the end-to-end (E2E) testing framework for the retina project. The main update is addition of running perf tests in advanced mode for Retina. The other updates involve the addition of new utility functions, refactoring of existing code for better modularity, and improvements to the performance testing workflow.

New Utility Functions:

  • Added RetinaChartPath, RetinaAdvancedProfilePath, and KubeConfigFilePath functions to dynamically generate file paths. (test/e2e/common/common.go)

Refactoring:

  • Moved the CreateAzureTempK8sInfra function to a new file azure_temp_infra_setup.go to modularize infrastructure setup. (test/e2e/infra/azure_temp_infra_setup.go)
  • Removed redundant code and simplified the TestE2ERetina and TestE2EPerfRetina functions by using new utility functions and the CreateAzureTempK8sInfra function. (test/e2e/retina_e2e_test.go, test/e2e/retina_perf_test.go) [1] [2]

Performance Testing:

  • Moved the performance test logic to a new file perf.go and added support for running tests in different retina modes (basic, advanced). (test/e2e/jobs/perf.go)
  • Updated the PublishPerfResults function to include the retina mode in telemetry data. (test/e2e/scenarios/perf/publish-perf-results.go)

Code Cleanup:

  • Removed unused imports and redundant code blocks from various files to improve readability and maintainability. (test/e2e/jobs/jobs.go, test/e2e/scale_test.go) [1] [2]

These changes collectively enhance the modularity, readability, and functionality of the E2E testing framework, making it easier to maintain and extend in the future.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • [] I have updated the documentation, if necessary.
  • [] I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

I have tested the relevant changes locally and have verified that it works as nintended.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@ritwikranjan ritwikranjan requested a review from a team as a code owner January 17, 2025 17:28
@ritwikranjan ritwikranjan added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@ritwikranjan ritwikranjan added this pull request to the merge queue Jan 22, 2025
Merged via the queue into microsoft:main with commit 8fb1c57 Jan 22, 2025
26 checks passed
@ritwikranjan ritwikranjan deleted the feat/perf-test-advanced branch January 22, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants