Skip to content

Commit

Permalink
[IR] Remove mkdirs call in external tensor save (#2033)
Browse files Browse the repository at this point in the history
The user should ensure the directory exists. This is consistent with the
behavior of `torch.export.save` and other python methods.
  • Loading branch information
justinchuby authored Jan 23, 2025
1 parent cada10e commit e673351
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions onnxscript/ir/external_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,6 @@ def convert_tensors_to_external(
should match the input tensor order.
"""
path = os.path.join(base_dir, relative_path)
# Check if file path is valid, and create subsequent subdirectories within the path if they don't exist
os.makedirs(os.path.dirname(path), exist_ok=True)

# Check if output path exists. Load pre-existing external data if it does.
if os.path.exists(path):
Expand Down

0 comments on commit e673351

Please sign in to comment.